feat: First pass downloadMany #1945
Conversation
product-auto-label
bot
added
the
api: storage
| public void downloadBlobs() {} | ||
| public void downloadBlobs() throws IOException { | ||
| TransferManagerConfig config = | ||
| TransferManagerConfig.newBuilder().setAllowChunking(false).setMaxWorkers(1).build(); |
There was a problem hiding this comment.
Isn't setAllowChunking false by default?
There was a problem hiding this comment.
yes it is, can remove that.
|
|
||
| @Override | ||
| public DownloadResult call() throws Exception { | ||
| // TODO: Check for chunking |
There was a problem hiding this comment.
What's the plan here? To check setAllowChunking, and decide whether to download byte stream ?
There was a problem hiding this comment.
yes, we would check allowChunking from the ParallelDownloadConfig first to ensure that the customer is allowing us to chunk downloads on their behalf, then we would check the file size to see if we want to do direct or chunked download.
| @@ -56,6 +56,14 @@ public TransferManagerImpl(TransferManagerConfig transferManagerConfig) { | |||
|
|
|||
| @Override | |||
| public @NonNull DownloadJob downloadBlobs(List<BlobInfo> blobs, ParallelDownloadConfig opts) { | |||
There was a problem hiding this comment.
docs will be a followup, just getting first passes out first.
|
Overall the implementation looks good to me. I will leave it to the Java experts to look more closely at the specifics. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.